GH-4428: (Enhancement) Fix typos and enhance TextSplitter with Document property preservation and chunk tracking #4429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix typos in
spring-ai-commonsand enhanceTextSplitterto preserve Document properties and add chunk tracking for better RAG system support.Current Issues
IdGenerator.java: "dependant" should be "dependent"TextSplitter.java: Comment contains "slit" instead of "split"scorevalues are lost during splittingChanges Made
1. Typo Fixes
2. TextSplitter Enhancements
scorevalues in all chunksparent_document_id,chunk_index,total_chunks3. Test Updates
Enhanced Metadata Example
Benefits
Testing
testScorePreservation(): Verifies score preservationtestParentDocumentTracking(): Validates parent trackingtestChunkMetadataInformation(): Tests chunk position metadatatestEnhancedMetadataWithMultipleDocuments(): Multi-document scenariosTextSplitterTests.java: Fixed test assertions for enhanced metadataTokenTextSplitterTest.java: Updated to validate chunk-specific fieldsFiles Modified
IdGenerator.java: Typo fix in JavaDocTextSplitter.java: Typo fix + enhanced functionalityTextSplitterTests.java: Updated tests + new test coverageTokenTextSplitterTest.java: Updated tests for enhanced metadata validationcoverageUse Case
This enables proper chunk-to-document relationships essential for effective RAG systems while improving overall code quality.
closes #4428